Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): make dev ssr bundling lazy #28149

Merged
merged 11 commits into from
Nov 23, 2020
Merged

Conversation

KyleAMathews
Copy link
Contributor

Similar to lazy client bundling PR #27884

Saves a significant amount of time on bootup

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2020
@ascorbic ascorbic added topic: resource loading* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 19, 2020
await getPageDataExperimental(pageObj.path)

// Wait for public/render-page.js to update w/ the page component.
await ensurePathComponentInSSRBundle(pageObj, directory)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is the meat of the change

gatsbybot pushed a commit that referenced this pull request Nov 19, 2020
* fix(gatsby): pull out a few bug fixes from #28149

* Add missing fix
vladar pushed a commit that referenced this pull request Nov 19, 2020
* fix(gatsby): pull out a few bug fixes from #28149

* Add missing fix

(cherry picked from commit f9fd11d)
gatsbybot added a commit to gatsbyjs/gatsby-starter-mdx-basic that referenced this pull request Nov 19, 2020
…186)

* fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149

* Add missing fix
gatsbybot added a commit to gatsbyjs/gatsby-starter-notes-theme that referenced this pull request Nov 19, 2020
…186)

* fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149

* Add missing fix
gatsbybot added a commit to gatsbyjs/gatsby-starter-theme that referenced this pull request Nov 19, 2020
…186)

* fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149

* Add missing fix
gatsbybot added a commit to gatsbyjs/gatsby-starter-hello-world that referenced this pull request Nov 19, 2020
…186)

* fix(gatsby): pull out a few bug fixes from gatsbyjs/gatsby#28149

* Add missing fix
vladar added a commit that referenced this pull request Nov 19, 2020
* fix(gatsby): pull out a few bug fixes from #28149

* Add missing fix

(cherry picked from commit f9fd11d)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@KyleAMathews KyleAMathews merged commit 70b81a6 into master Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the lazy-ssr-bundling branch November 23, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants