Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby-transformer-asciidoc): Improve doc for CustomConverter #27512

Merged
merged 1 commit into from
Oct 20, 2020
Merged

docs(gatsby-transformer-asciidoc): Improve doc for CustomConverter #27512

merged 1 commit into from
Oct 20, 2020

Conversation

bitPogo
Copy link
Contributor

@bitPogo bitPogo commented Oct 17, 2020 •
edited
Loading

Description

This patch makes a correction to the actual Custom Converter section of
the documentation in gatsby-transformer-asciidoc. It is referenced by current version
as a TemplateConverter, but is in fact a CustomConverter.
This patch also extends the doc regarding the actual usage.

Related Issues

closes #27511

@bitPogo
Improve doc for CustomConverter in gatsby-transformer-asciidoc
98d2c0e 
This patch makes a correction to the actual CustomConverter section of
the documentation in gatsby-transformer-asciidoc. It was referenced by
as TemplateConverter, but is in fact a CustomConverter.
This patch also extends the doc regarding the actual usage and closes gatsbyjs#27511.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 17, 2020
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 19, 2020
pvdz
pvdz approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to match the name in their docs so let's use that here as well. Thank you 💜

@pvdz pvdz merged commit 192ad80 into gatsbyjs:master Oct 20, 2020
@pvdz pvdz changed the title Improve doc for CustomConverter in gatsby-transformer-asciidoc docs(gatsby-transformer-asciidoc): Improve doc for CustomConverter Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-transformer-asciidoc - Misnamed option
3 participants
@bitPogo @pvdz @LekoArts