Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional logging around conditional page builds #26748

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Add additional logging around conditional page builds #26748

merged 4 commits into from
Sep 4, 2020

Conversation

herecydev
Copy link
Contributor

Resolves #26741

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 1, 2020
@pieh pieh added topic: build Related to the Gatsby build process and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 3, 2020
@pieh pieh self-assigned this Sep 3, 2020
pieh
pieh approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great!

I did small formatting "tweaks" to be more uniform with the rest (even tho it wasn't strictly breaking linting)

@pieh pieh merged commit 9fbac50 into gatsbyjs:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
topic: build Related to the Gatsby build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional Page Builds do not work
2 participants
@herecydev @pieh