-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using default breakpoints
has unexpected results on my constrained
images
#33959
Comments
Hi! Sorry to hear you're running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you're able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it. If you're up for it, we'd very much appreciate if you could provide a minimal reproduction and we'll be able to take another look. Thanks for using Gatsby! 💜 |
Hey @LekoArts , I've set up https://github.com/laurenskling/constrained-images-use-breakpoints here (https://github.com/laurenskling/constrained-images-use-breakpoints/blob/main/gatsby-config.js#L38) it uses default breakpoints. If you go to
The result will contain among others:
I'm requesting a max image of |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
I still feel like this is something we should discuss |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Preliminary Checks
Description
(originally posted as discussion, but I believe this to be a bug #33877)
Constrained images use the
outputPixelDensities
feature. That feature clearly states:Ignored for full width layout images, which use breakpoints instead.
So I find it strange that constrained images actually do use the
breakpoints
feature. I noticed this when I set default breakpoints in thegatsby-plugin-sharp
options.I actually found out that my constrained image is not using the
outputPixelDensities
because of my default breakpoints. It is only slicing the width I request and the breakpoint widths, not the sizes it should take from (default or set)outputPixelDensities
.Reproduction Link
Sorry, dont have one now
Steps to Reproduce
as suggested at: https://www.gatsbyjs.com/plugins/gatsby-plugin-image/#customizing-the-default-options
Expected Result
I think only FULL_WIDTH images should use the
breakpoints
settingActual Result
a constrained image will slice the
breakpoint
widths, which don't make sense for constrained images.Environment
Config Flags
No response
The text was updated successfully, but these errors were encountered: