Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workbox to v5 in gatsby-plugin-offline #28287

Closed
kije opened this issue Nov 25, 2020 · 5 comments · May be fixed by #31542
Closed

Upgrade workbox to v5 in gatsby-plugin-offline #28287

kije opened this issue Nov 25, 2020 · 5 comments · May be fixed by #31542
Labels
stale? Issue that may be closed soon due to the original author not responding any more. topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Comments

@kije
Copy link

kije commented Nov 25, 2020

Description

gatsby-plugin-offline currently uses workbox v4, which is outdated and should be updated to the latest v5 version

@kije kije added the type: bug An issue or pull request relating to a bug in Gatsby label Nov 25, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 25, 2020
@LekoArts LekoArts added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: bug An issue or pull request relating to a bug in Gatsby labels Nov 26, 2020
@LekoArts
Copy link
Contributor

Feel free to send in a PR upgrading it and laying out if/how breaking changes would affect the plugin :)

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 4, 2021
@github-actions
Copy link

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@kije
Copy link
Author

kije commented May 22, 2021

@LekoArts sorry for the inactivity here. I finally found some time to investigate this, and I prepared a PR that upgrades the workbox version to the latest version (v6).
The upgrade required some changes to the "architecture" of the plugin. I outlined them in the PR.

@RectoVersoDev
Copy link

Hi everyone, any update on this ? The bot closed the issue but workbox version is still 4.3.1 (published 4 years ago!).

It would be really cool to use the latest version of workbox in the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
3 participants