Restructure gardenlinux to clean up code and logic
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
feature/oci-restructure
branch
4 times, most recently
from
b6bd62b to
31be9b8
Compare
NotTheEvilOne
changed the title
gardenlinux.oci to remove clean up code and logicgardenlinux.oci to clean up code and logic
NotTheEvilOne
force-pushed
the
feature/oci-restructure
branch
5 times, most recently
from
749969d to
f40e9cf
Compare
NotTheEvilOne
changed the title
gardenlinux.oci to clean up code and logicgardenlinux to clean up code and logic
NotTheEvilOne
force-pushed
the
feature/oci-restructure
branch
from
0dbaa76 to
a310877
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
feature/oci-restructure
branch
4 times, most recently
from
a191279 to
33feb2f
Compare
yeoldegrove
approved these changes
Jun 5, 2025
Contributor
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
Overall, great work!
Local tests are actually failing for me pretty constantly with a 400 error (seems unrelated). #116 fixes this for me.
A little nit-pick would be adding doc-strings to every public function as you also fixed the docs generation (not tested).
Closed
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
feature/oci-restructure
branch
from
33feb2f to
91aa251
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
…srcFile` Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors the code in
gardenlinux.ociand restructurespython_gardenlinux_libto clean up code and logic.Which issue(s) this PR fixes:
Closes #110
Closes #116