Add DualStack Support #131
Conversation
|
@mohamed-rafraf Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @mohamed-rafraf for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
pkg/api/v1alpha1/provider_spec.go
Outdated
| // DualStack enables the creation of machines with both IPv4 and IPv6 support. | ||
| // This allows seamless integration into modern, dual-stack network environments. | ||
| DualStack bool `json:"dualStack"` | ||
|
|
There was a problem hiding this comment.
MCM providers are kinda considered lower level API. So:
- I would consider adding them to the NIC. It either way seems like for GCP the "dual stack" is part of the NIC settings.
- I would expose them as is: meaning 2 different settings mirroring what the GCP client provides. provider-gcp can then configure it accordingly.
pkg/gcp/machine_controller_util.go
Outdated
| if providerSpec.DualStack { | ||
| computeNIC.StackType = "IPV4_IPV6" | ||
| computeNIC.Ipv6AccessType = "EXTERNAL" | ||
| } |
There was a problem hiding this comment.
see comment above regarding the configuration.
|
Hi @mohamed-rafraf, can you use https://github.com/rishabh-11/gen-crd-api-reference-docs to generate the provider-spec docs? The upstream one has a bug that has not been fixed yet. I have incorporated the fix in my fork. |
|
@rishabh-11 Thank you |
|
@mohamed-rafraf can you pull the latest master branch of mcm-provider-gcp and regenerate the doc? The tpl files for gen-crd-api-doc were incorrect before. |
gardener-robot
added
size/s
What this PR does / why we need it:
This PR will allow the GCP provider for Machine Controller Manager create Virtual Machines with IPv6
Which issue(s) this PR fixes:
Fixes #829
Special notes for your reviewer:
Release note: