-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Maestro e2e tests for RN #1313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@boorad is attempting to deploy a commit to the Garden Computing Team on Vercel. A member of the Team first needs to authorize it. |
gdorsi
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Maestro end-to-end tests that click through an app and assert what is on the screen of a simulator.
To test Jazz functionality, it exercises the
chat-rn
example application through login, logout, starting a chat, sending a message, and getting an invite code.The Github Actions workflow builds the app with
xcodebuild
in arelease
variant so we don't have to run the Metro bundler. This may add some time to the execution, but simplifies the flow, as we don't have to deal with Expo startup screens and grabbing Metro logs for diagnosing errors, etc. This can be changed in the future if the runtimes are too long.This change also consolidated some of the source code dependency install and build steps into a composite action that can be shared across workflows.