Fixes to CParser #51
Merged
Fixes to CParser #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes the tests in gap-system/gap#2628 pass. I can't say that I understand |
fingolfin
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
I really have no idea how that code works, and would rather not try to understand it. On a quick cursory examination, it all seems sane. Since you dug into it, and it works for you, that's enough for me.
But of course it'd be great if @rbehrends could have a look, too.
ward/cparser.lua
Outdated
| @@ -546,6 +546,38 @@ local function build_for_stmt(init, cond, step, body) | |||
| return init_node, exit_node | |||
| end | |||
|
|
|||
| local function build_compount_stmt_local_variables(str, pos, declarations) | |||
|
Thanks, that was a rather embarrassing typo. |
rbehrends
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
compound_statementby pulling a large inline function out of the ruleint sz = size((int []){ });to be parsedThe changes come in three commits. I could open 3 separate PRs, if this is requested.