Minor cleanup for group isomorphism #965
Conversation
Also fix to typo in test file. Redo change that was accidentally overwritten by merge
|
@hulpke Thanks for cleaning up the tests - I am now revising on |
Current coverage is 49.42% (diff: 36.20%)@@ master #965 diff @@
==========================================
Files 424 424
Lines 222810 222845 +35
Methods 3430 3430
Messages 0 0
Branches 0 0
==========================================
+ Hits 110143 110152 +9
- Misses 112667 112693 +26
Partials 0 0
|
| @@ -63,8 +63,6 @@ gap> H:=PcGroupCode( | |||
| > 2361539190251190837914203692538788582942691934753704906691,20000);; | |||
| gap> IsomorphismGroups(G,H); | |||
| fail | |||
| gap> IsomorphismGroups(G,PcGroupCode(CodePcGroup(G),Size(G)))=fail; | |||
| false | |||
There was a problem hiding this comment.
Actually, in my attempts the command above passed the test with -o 1g setting, though it probably took too long. However, another call to IsomorphismGroups below caused running out of memory limits:
@@ -107,8 +107,6 @@ gap> H:=PcGroupCode(18738408935359210460657231881739776911013615108923450662760,
> 21952);;
gap> IsomorphismGroups(G,H);
fail
-gap> IsomorphismGroups(G,PcGroupCode(CodePcGroup(G),Size(G)))=fail;
-false
gap> G:=PcGroupCode(49879636940338958988550512603242447645113136854728735,
> 15552);;
so maybe we need to remove it as well (I am happy to move it to benchmarks - just looked at them in #966).
| @@ -542,7 +542,7 @@ local id,m,epi; | |||
| # following is stopgap for L | |||
| id:=DataAboutSimpleGroup(G); | |||
| if id.idSimple.series="A" then | |||
| Info(InfoLattice,1,"Alternating recognition needed!"); | |||
| Info(InfoPerformance,1,"Alternating recognition needed!"); | |||
| elif id.idSimple.series="L" then | |||
There was a problem hiding this comment.
@hulpke: It actually will not work - InfoPerformance has level 1 when GAP starts. You can check this with make testinstall - the 1st of the log files with have these messages.
|
@hulpke I've merged this after removing some more tests - at least now the test should complete, and we can merge further PRs. |
This fixes minor issues that only became apparent after the previous merge (of PR #896)