Some improvements for LatticeByCyclicExtension #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation of LatticeByCyclicExtension, the optional second argument can be either a function, or a list of two functions. The latter did not actually work, which is now fixed.
fingolfin
added
the
kind: bug
Current coverage is 49.22% (diff: 75.00%)@@ master #905 diff @@
==========================================
Files 423 423
Lines 229156 229171 +15
Methods 3448 3448
Messages 0 0
Branches 0 0
==========================================
+ Hits 112717 112815 +98
+ Misses 116439 116356 -83
Partials 0 0
|
fingolfin
force-pushed
the
mh/fix-grplatt
branch
from
87afefc to
56bdafe
Compare
These are based on the assumption that computing the order of a group element cannot be harder than computing the size of the group, and in general is faster
This variant of Zuppos is currently undocumented, but used internally by LatticeByCyclicExtension. This change speeds it as follows: 1. If Zuppos(G) is already known, it is faster to simply filter that list. 2. It replaces Group(c) by Subgroup(G,[c]), which makes things faster if G is a IsHandledByNiceMonomorphism group (such as an automorphism group). 3. In addition, it only creates this subgroup once (not twice as before), which can lead to further improvements.
Note that there are immediate methods which set IsTrivial suitably as soon as the Size is known, hence these changes do not break any existing use case. However, there are examples where computing Size is infeasible, but computing IsTrivial is possible, sometimes even trivial.
fingolfin
force-pushed
the
mh/fix-grplatt
branch
from
56bdafe to
d3f5e45
Compare
|
I added some more changes, which make the fixed variants of |
|
I'm very happy with the changes. |
fingolfin
changed the title
|
This PR caused a diff in the manual example - I am going to update it to match the new output. |
olexandr-konovalov
pushed a commit
that referenced
this pull request
Oct 15, 2016
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation of LatticeByCyclicExtension, the optional
second argument can be either a function, or a list of two functions.
The latter did not actually work, which is now fixed
I guess @hulpke is the person best qualified to evaluate this change.