Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrintPPerm4 on big endian machines #782

Merged
merged 1 commit into from
May 6, 2016
Merged

Fix PrintPPerm4 on big endian machines #782

merged 1 commit into from
May 6, 2016

Conversation

jamesjer
Copy link
Contributor

@jamesjer jamesjer commented May 5, 2016

The Fedora PowerPC64 team tried to build gap 4.8.3 but hit a test failure in pperm.tst. The QuoPPerm22 part of the bug was fixed in git in mid-April. This fixes the only other case of the codegree being accessed with the wrong bit width, which accidentally works on little endian architectures like the x86 if the codegree is < 65536, but doesn't work on big endian machines.

@james-d-mitchell
Copy link
Contributor

Looks good, thanks for the fix!

@james-d-mitchell james-d-mitchell merged commit b47ce25 into gap-system:master May 6, 2016
@markuspf
Copy link
Member

markuspf commented May 6, 2016

Just as a note, since this is a bugfix, it should probably have gone into stable-4.8. I just cherry-picked it across, but keep this in mind for future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants