Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection of enhancements #683

Merged
merged 4 commits into from
Mar 24, 2016
Merged

Collection of enhancements #683

merged 4 commits into from
Mar 24, 2016

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Mar 20, 2016

No description provided.

@ChrisJefferson
Copy link
Contributor

This looks good to me.

I would be interested in cases where PartitionStabilizerPermGroup is used, as I have a (hopefully) much improved version of this function in the ferret package, and would be interested to see how well it does on a range of problems.

@hulpke
Copy link
Contributor Author

hulpke commented Mar 20, 2016

@ChrisJefferson Thank you. Indeed when I created it I was hoping that someone who knows the backtrack better would implement a backtrack replacement (or have a backtrack method).

Currently it is only used in the library in the automorphism group calculation for solvable groups -- to descend from GL to a subgroup stabilizing certain subspaces.

@hulpke hulpke force-pushed the additions branch 2 times, most recently from 979d050 to d69be4b Compare March 23, 2016 16:42
@hulpke hulpke mentioned this pull request Mar 24, 2016
Closed
hulpke added 4 commits March 24, 2016 17:06
@hulpke
ENHANCE: LowIndexSubgroups as generic operation
628a4b5 
Also works (through maximal subgroups) for e.g. permutation groups.
@hulpke
ENHANCE: Improvement for PartitionStabilizerPermGroup
1123e53 
Run through subsets by order.
@hulpke
ENHANCE: Reduce degree of simple permutation factor
d394b0d 
if it is too large.
@hulpke
ENHANCE: Improve subgroup fetch from table of marks.
7e16584 
Use actual extension names used by table of marks library to avoid
issues of assigning fixed names.

Catch cases of TableOfMarks returning fail.
@hulpke hulpke merged commit f3cda31 into gap-system:master Mar 24, 2016
@olexandr-konovalov
Copy link
Member

@hulpke, it seems that this PR now causes the following diff:

########> Diff in /Volumes/hudson-fs/workspace/GAP-dev/GAPCOPTS/32build/GAPGMP\
/gmp/GAPTARGET/standard/label/fruitloop/GAP-git-snapshot/tst/teststandard/grpp\
erm.tst:90
# Input is:
m:=MaximalSubgroupClassReps(w);;
# Expected output:
# But found:
Error, <G> must be simple
########

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Mar 25, 2016
@olexandr-konovalov
Copy link
Member

@hulpke As this PR now merged, could you please document those changes that are worth highlighting in the changes manual and GAP 4.9 release announcement? The easiest way is to list them on wiki here: https://github.com/gap-system/gap/wiki/Changes-between-GAP-4.8-and-GAP-4.9

@hulpke
Copy link
Contributor Author

hulpke commented Mar 25, 2016

@alex-konovalov I suspect the error in grpperm.tst is due to fixes that are in stable, but not yet in master. Should I submit the same changes as a pull request to master, or will there be an automatic merge from stable to master in the foreseeable future?

@olexandr-konovalov
Copy link
Member

@hulpke there are no such things like "automatic" merges, but the right adjective to use would be "periodic merges". Time to time someone should make them. Sometimes they could go without merge conflicts, but now now - this is because of taking some HPC-GAP extensions out of the stable branch.

In any case, you don't have to submit another PR or do any cherry-picking for the changes that are already in the stable branch, since the merge should pick up those changes.

@hulpke hulpke mentioned this pull request Mar 28, 2016
Closed
@olexandr-konovalov
Copy link
Member

@hulpke very good - after the merge of my PR #696 the error disappeared as you've predicted.

@fingolfin fingolfin mentioned this pull request Sep 7, 2017
Closed
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
@fingolfin fingolfin mentioned this pull request Jan 30, 2018
Closed
hulpke added a commit to hulpke/gap that referenced this pull request Feb 1, 2018
@hulpke
REDO part of gap-system#683.
95cb1ec 
For some reason (probably my stupidity) par on gap-system#683 had fallen out of
master. Add again.
hulpke added a commit to hulpke/gap that referenced this pull request Feb 1, 2018
@hulpke
ENHANCE: Added manual to `LowIndexSubgroups'.
1eed10d 
as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
hulpke added a commit to hulpke/gap that referenced this pull request Feb 2, 2018
@hulpke
REDO part of gap-system#683.
9ef44af 
For some reason (probably my stupidity) par on gap-system#683 had fallen out of
master. Add again.
fingolfin pushed a commit to fingolfin/gap that referenced this pull request Feb 5, 2018
@hulpke @fingolfin
ENHANCE: Added manual to `LowIndexSubgroups'.
120b0fa 
as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
fingolfin pushed a commit to fingolfin/gap that referenced this pull request Feb 7, 2018
@hulpke @fingolfin
ENHANCE: Added LowIndexSubgroups to ref manual
8dcfd26 
as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
fingolfin pushed a commit to fingolfin/gap that referenced this pull request Feb 8, 2018
@hulpke @fingolfin
ENHANCE: Added LowIndexSubgroups to ref manual
9352b3b 
as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
fingolfin pushed a commit that referenced this pull request Feb 9, 2018
@hulpke @fingolfin
ENHANCE: Added LowIndexSubgroups to ref manual
e755b88 
as requested in #2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of #683, as for some reason (probably my stupidity)
part of #683 had fallen out of master. Added it again.
fingolfin pushed a commit to fingolfin/gap that referenced this pull request Mar 7, 2018
@hulpke @fingolfin
ENHANCE: Added LowIndexSubgroups to ref manual
bcf12d7 
as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hulpke @ChrisJefferson @olexandr-konovalov