Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence compiler warning about uninitialised #662

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Mar 8, 2016

  • variable curr_microseconds was potenially used uninitialised
  • just initialise it to 0 to silence the compiler

* variable curr_microseconds was potenially used uninitialised
* just initialise it to 0 to silence the compiler
@markuspf markuspf added kind: bug Issues describing general bugs, and PRs fixing them topic: tests issues or PRs related to tests labels Mar 8, 2016
@markuspf markuspf added this to the GAP 4.8.3 milestone Mar 8, 2016
@markuspf
Copy link
Member Author

markuspf commented Mar 8, 2016

I think we'll have to change the timeout tests in some way, they are too fragile at the moment. If noone else beats me to it I'll do it (later).

olexandr-konovalov pushed a commit that referenced this pull request Mar 9, 2016
Silence compiler warning about uninitialised
@olexandr-konovalov olexandr-konovalov merged commit 53e0a18 into gap-system:stable-4.8 Mar 9, 2016
@olexandr-konovalov
Copy link
Member

Merged, thanks @markuspf. The fix is obviously correct. Failed tests in Travis are due to the fragility of timeouts tests.

@markuspf markuspf deleted the fix-uninitalised-curr_microseconds branch February 5, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants