Skip to content

Conversation

@hulpke
Copy link
Contributor

@hulpke hulpke commented Feb 18, 2016

As this was a reported bug on short notice.

I have not been able to reduce the reported error examples to anything plausible for test files.

2nd attempt, now based off stable.

Also added the requested documentation fix for #613 that is already in master.

@olexandr-konovalov
Copy link
Member

Thanks @hulpke - there is no promise that this will go into 4.8.2, but then we may include the fix into 4.8.3.

My only concern is that this PR changes the level of many assertions, and this may have side-effect on tests that depend on randomness. Wasn't our intention to follow the newly suggested guidelines for assertion levels (#564) in the master branch, and not in stable-4.8 ?

This fixes the bugs reported by macaj@dcs.fmph.uniba.sk
@hulpke
Copy link
Contributor Author

hulpke commented Feb 21, 2016

I have tried to change the changes to leave out the assertion changes. Somehow this deleted @fingolfin 's comment -- sorry!.

As far as I'm concerned it does not need to go into 4.8.2, its just an option.

@fingolfin
Copy link
Member

@hulpke You didn't do anything wrong! My comments were attached to the commit, and since you replaced the commit, they are not visible anymore -- but that's intended behavior. After all, you fully addressed my request with your change (thank you).

There is no concern with this anymore, so I am merging it now.

fingolfin added a commit that referenced this pull request Feb 21, 2016
2 minor fixes, including for the bug reported by macaj@dcs.fmph.uniba.sk
@fingolfin fingolfin merged commit 55570b1 into gap-system:stable-4.8 Feb 21, 2016
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.8.3 milestone Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants