julia_gc: compensate for Julia guard pages #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids triggering Julia's `safe_restore` mechanism completely in my local tests, i.e., avoids causing a segfault by scanning right into the guard pages set up by Julia. Note that this is unrelated to the recently removed `SKIP_GUARD_PAGES` feature which was about adjusting for pthread guard pages, which in practice turns out to be irrelevant for our purposes.
fingolfin
added
topic: kernel
topic: julia
fingolfin
added
backport-to-4.13-DONE
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids triggering Julia's
safe_restoremechanism completely in my local tests, i.e., avoids causing a segfault by scanning right into the guard pages set up by Julia.Note that this is unrelated to the recently removed
SKIP_GUARD_PAGESfeature which was about adjusting for pthread guard pages, which in practice turns out to be irrelevant for our purposes.I'd like to backport this to stable-4.13 ASAP and then release 4.13.1