Fix an error in MinimalFaithfulPermutationDegree, for the case of abelian direct factors
#5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If normal subgroups have abelian factors, intersection can only be avoided, if both normals have abelian factor, not if only one has. This fixes gap-system#5729
hulpke
added
kind: bug: wrong result
fingolfin
changed the title
MinimalFaithfulPermutationDegree, for the case of abelian direct factors
fingolfin
added
release notes: use title
fingolfin
approved these changes
May 28, 2024
fingolfin
pushed a commit
that referenced
this pull request
Jun 9, 2024
If normal subgroups have abelian factors, intersection can only be avoided, if both normals have abelian factor, not if only one has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If normal subgroups have abelian factors, intersection can only be avoided, if both normals have abelian factor, not if only one has, as the code did erraneously.
Also set min degree of trivial group to 0, not 1
This fixes #5729
Release note:
An error in
MinimalFaithfulPermutationDegree, for the case of abelian direct factors, was fixed.