-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP -- Accumulators (do not merge) #567
base: master
Are you sure you want to change the base?
Conversation
of making Random permutations for testing.
Also a library implementation of lazy permutation accumulators
Further progress, especially binding kernel functions to operations
e234989
to
467a501
Compare
Still lacks documentation and is built on the random-sources PR which breaks some tests. |
Replacing SCRSift by a version using an accumulator makes basically no difference to run-time and reduces garbage created by roughly half on one benchmark (size of a Sylow subgroup of S_350). |
So what is the general idea here -- would we (potentially) also offer accumulators for things like integers, vectors, matrices? I.e. is this meant to be a generic interface for "in-place" operations? That sounds potentially quite useful |
@fingolfin See issue #550. We already have mutable vectors and matrices and suitable operations to modify them in place. This is for objects that do not have mutable versions. |
For anyone who is interested. Still lacks kernel code, documentation, tests, etc. etc.