Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP -- Accumulators (do not merge) #567

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stevelinton
Copy link
Contributor

For anyone who is interested. Still lacks kernel code, documentation, tests, etc. etc.

@olexandr-konovalov olexandr-konovalov added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Feb 1, 2016
Also a library implementation of lazy permutation accumulators
Further progress, especially binding kernel functions to operations
@stevelinton
Copy link
Contributor Author

Still lacks documentation and is built on the random-sources PR which breaks some tests.
If anyone is interested, my next plan is to try building versions of some of the stabchain functions on this and see if it makes a time or memory difference.

@stevelinton
Copy link
Contributor Author

Replacing SCRSift by a version using an accumulator makes basically no difference to run-time and reduces garbage created by roughly half on one benchmark (size of a Sylow subgroup of S_350).

@fingolfin
Copy link
Member

So what is the general idea here -- would we (potentially) also offer accumulators for things like integers, vectors, matrices?

I.e. is this meant to be a generic interface for "in-place" operations? That sounds potentially quite useful

@stevelinton
Copy link
Contributor Author

stevelinton commented Jan 22, 2017

@fingolfin See issue #550. We already have mutable vectors and matrices and suitable operations to modify them in place. This is for objects that do not have mutable versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants