Fix an issue where closing a subprocess started via InputOutputLocalProcess could lead to spurious error messages by that subprocess
#5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we see issues like this on Linux:
gap> d := DirectoryCurrent();;
gap> f := Filename(DirectoriesSystemPrograms(), "rev");;
gap> s := InputOutputLocalProcess(d,f,[]);;
gap> Sleep(1);
gap> CloseStream(s); Print("\n");
rev: stdin
fingolfin
added
kind: bug
fingolfin
force-pushed
the
mh/kill-before-close
branch
from
f92de30 to
458b8a5
Compare
ChrisJefferson
approved these changes
Mar 11, 2024
|
There is no perfect way to shut down child processes, but this seems better than before, and I can't find any way it is worse than before. |
fingolfin
added
the
release notes: use title
fingolfin
changed the title
InputOutputLocalProcess could lead to spurious error messages by that subprocess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we see issues like this on Linux:
See oscar-system/GAP.jl#971 by @ThomasBreuer