Fix error in MaximalAbelianQuotient applied to a subgroup of an FPGroup which could result in wrong results
#5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not try the orbit mapping test for cyclic subgroups (or subgroups with many orbits). Thiscould be memory intensive, and is done reasonably by backtrack. This resolves gap-system#5564
Replace method for `MaximalAbelianQuotient` for a subgroup with an easier version that rewrites the presentation and then abelianizes. This fixes gap-system#5609
Only attempt refinements with PCore, Agemo, Omega, if steps are not already elementary abelian. This can avoid expensive subcomputations.
hulpke
added
the
release notes: to be added
fingolfin
added
kind: bug
fingolfin
changed the title
fingolfin
added
release notes: use title
fingolfin
approved these changes
Feb 2, 2024
|
|
||
| #InstallMethod(MaximalAbelianQuotient, | ||
| # "subgroups of fp. abelian rewriting", true, [IsSubgroupFpGroup], 0, |
There was a problem hiding this comment.
Is there a reason for commenting this out rather than just deleting it? The function can be recovered from git if it's needed again.
fingolfin
changed the title
MaximalAbelianQuotient applied to a subgroup of an FPGroup which could result in wrong results
fingolfin
removed
the
release notes: to be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AGSRCharacteristicSeriesText for release notes
An error in evaluating the MaximalAbelianQuotient of a subgroup of an FPGroup was fixed. This error could have produced wrong results.