kernel: revise formats supported by Pr and Emit
#5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were not used (anymore). Also remove the only other remaining occurrence in src/compiler.c of %s.
Instead use %C in the single caller. This is arguably more correct (except that %C itself is insufficient right now)
It was a rarely used synonym for %d
Also clarify %g documentation.
We used to only have %I which expects a C string; this was later joined by %H which does the same but takes a GAP string. In the meantime, all uses of %I were replaced by %H as in all cases this was necessary for GC safety. Since %I is for printing "identifiers" it seems sensible to keep that format name instead of %H which was only used because H is the next letter after I but which otherwise has no special meaning.
fingolfin
added
topic: kernel
release notes: not needed
ChrisJefferson
approved these changes
Jan 4, 2024
|
I did verify that no packages have kernel extensions calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some motivation and background, see also my comments in #5546