Fix off-by-one error in CopyListEntries that could end up creating lists in which the last element is unbound
#4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of the list may be changed if we add new members to the list to the end of list, or unbind the final element.
|
In GAP 4.4, when this wasn't a kernel function yet, the problematic code triggered an error. I wonder: do we really want to support copying "unbound entries" via |
fingolfin
added
kind: bug
fingolfin
approved these changes
Jul 6, 2022
|
Banning copying unbound members would mean we couldn't use SyMemmove for the most efficient case (although this function seems to do lots of things, I wonder how often it's even used with a step value other than 1?) |
fingolfin
added
the
release notes: use title
fingolfin
changed the title
CopyListEntries that could end up creating lists in which the last element is unbound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length of the list may be changed if we add new members to the
list to the end of list, or unbind the final element.
Fixes #4927