Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when QuitGap is called while reading from an InputTextString #4823

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

ChrisJefferson
Copy link
Contributor

Fixes #4820

I don't really like this, but I also don't have a better option.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) topic: kernel labels Mar 10, 2022
@ChrisJefferson ChrisJefferson changed the title Do not call back into GAP code when we are already quitting BugFix: Stop crash when QuitGap is called while reading from an InputTextString Mar 10, 2022
@ChrisJefferson ChrisJefferson changed the title BugFix: Stop crash when QuitGap is called while reading from an InputTextString BugFix: Fix crash when QuitGap is called while reading from an InputTextString Mar 10, 2022
@ChrisJefferson
Copy link
Contributor Author

The title isn't quite right, but is a simplified explanation for release notes

src/io.c Outdated Show resolved Hide resolved
@fingolfin fingolfin merged commit 21354bd into gap-system:master Mar 10, 2022
@ChrisJefferson ChrisJefferson deleted the fix-read-string branch April 1, 2022 08:17
@fingolfin fingolfin changed the title BugFix: Fix crash when QuitGap is called while reading from an InputTextString Fix crash when QuitGap is called while reading from an InputTextString Aug 17, 2022
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault doing ./gap -A -c 'FORCE_QUIT_GAP(TestPackage("aclib"));'
2 participants