Fix WreathProduct to return correct generators when given a matrix group and an intransitive top group
#4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriedrichRober
added
the
release notes: use title
|
I will add a small test later. |
FriedrichRober
changed the title
Generators of Matrix Wreath Product.Generators of Matrix Wreath Product with Intransitive Topgroup.
FriedrichRober
changed the title
Generators of Matrix Wreath Product with Intransitive Topgroup.Generators of Matrix Wreath Product with Intransitive Top Group.
FriedrichRober
force-pushed
the
fr/MatWreathProductGenerators
branch
from
3f3e23d
to
cc55e1f
Compare
FriedrichRober
changed the title
Generators of Matrix Wreath Product with Intransitive Top Group.
FriedrichRober
changed the title
FriedrichRober
force-pushed
the
fr/MatWreathProductGenerators
branch
from
cc55e1f
to
3f1a544
Compare
It was implicitely assumed that the top group is transitive, resulting in insufficient generators for the base group of the matrix wreath product if the top group was given intransitive. Add test to `testbugfix`.
FriedrichRober
force-pushed
the
fr/MatWreathProductGenerators
branch
from
3f1a544
to
5d9d66d
Compare
|
Ok, this is now ready for review. |
hulpke
approved these changes
Sep 24, 2021
fingolfin
added
kind: bug
fingolfin
changed the title
WreathProduct to return correct generators when given a matrix group and an intransitive top group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was implicitely assumed that the top group is transitive,
resulting in insufficient generators for the base group of the matrix wreath product
if the top group was given intransitive.
Further details
Closes #4663