-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (rare) wrong result for stabilizer computations #4660
Conversation
@@ -2056,11 +2056,16 @@ end ); | |||
## | |||
#F DixonSplit(<D>) . . calculate matrix,split spaces and obtain characters | |||
## | |||
InstallGlobalFunction( DixonSplit, function(D) | |||
local r,i,j,ch,ra,bsm, | |||
InstallGlobalFunction( DixonSplit, function(arg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is never called with the new argument, though, right? So is this for future work, or just for manual invocations by "super expert users"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter.
if they are few and would require maximals of lagbe almost simple group.
Handle generators/inverses that get killed Module rules before tails 2-cohom normalform rws *is* created confluent
if trivial image
If the group order is known, the generic orbit stabilizer might stop enumerating the orbit if one can deduce that it could not grow anymore for divisibility reasons. In this case the stabilizer in rare cases might still be too small and need to be corrected. This was done not fully. Thsi fixes gap-system#4659
A fix for #4659 and a number of small improvements (which are added so I don't need to wait for another approving review)
Text for release notes