-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve chapter 4 "The Programming Language" of the reference manual #4547
Conversation
doc/ref/language.xml
Outdated
<Item>function literals (see section <Ref Sect="Function"/>),</Item> | ||
<Item>function calls (see section <Ref Sect="Function Calls"/>),</Item> | ||
<Item>integer literals (see chapter <Ref Chap="Integers"/>),</Item> | ||
<Item>floating point literals (see chapter <Ref Chap="Floats"/>),</Item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that floats were missing in the list before this PR
<Item></Item> | ||
</Row> | ||
<Row> | ||
<Item> <C>^</C></Item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am abusing non breaking spaces here to force the tables to look not too bad, as a workaround for lack in GAPDoc of a way to merge table cells (something like HTML's colspan attribute for tables) 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a quick look. The precedence table is a very nice addition.
<Item></Item> | ||
</Row> | ||
<Row> | ||
<Item> <C>^</C></Item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
342976e
to
413c66b
Compare
Any more thoughts on this, @wilfwilson ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple, and a good improvement, thanks. I will merge when the tests pass again.
<Item></Item> | ||
</Row> | ||
<Row> | ||
<Item> <C>^</C></Item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I like it.
- turned list of "basic" expressions into an actual list - made the references in that list better - add a table listing the precedence and associativity of various operators - turned sections discussing various kinds of statements into subsections of the "Statements" section
Before it was listed under "Statements", even though it describes an expression (a literal, to be precise).
413c66b
to
7173f7e
Compare
No description provided.