Enable color prompt by default #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: to be added
fingolfin
added
the
gapdays2021-spring
ssiccha
approved these changes
Feb 18, 2021
wucas
approved these changes
Feb 18, 2021
|
Just to join in, I'm in favour of this |
frankluebeck
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
I'm using the color prompt since I introduced it without any problem. Very often when I show people some GAP usage in a talk or privately I'm asked how to enable this colored prompt.
So, I support changing the default. But, of course, this should be mentioned quite prominently in the release notes, including a hint how to get back the old standard behaviour.
|
I've added a suggestion for the release notes text; feel free to suggest improvements. |
ThomasBreuer
added a commit
to ThomasBreuer/gap
that referenced
this pull request
Feb 22, 2021
... to the change of the default (see gap-system#4274), and make the function `ColorPrompt` readonly
ThomasBreuer
added a commit
that referenced
this pull request
Feb 22, 2021
... to the change of the default (see #4274), and make the function `ColorPrompt` readonly
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a lot of people are missing out of this; and it should be safe for most. If this turns out to be wrong (as in: we get lots of complaints from people where it broke), we can still go back to the old default.
But perhaps I am missing other reasons that speak against it? @frankluebeck might have some suggestions.
Should IMHO be added to release notes because while being trivial and minor, it
has a very user visible effect, so people will notice, and may wonder.
Text for release notes
Enable colorized input prompts by default
GAP has supported colorized input prompts for a long time, but this feature was off by default. With this release, it is now on by default. Should you prefer the old behaviour, you can get it back by setting the
UseColorPromptuser preference to false. For example, by entering these commands:SetUserPreference( "UseColorPrompt", false ); WriteGapIniFile();