Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CoefficientsQadic for long results #4186

Merged

Conversation

frankluebeck
Copy link
Member

This doesn't seem to be slower for small input, but is dramatically
faster for long return values (using a divide and conquer recursion).

Also added some calls of this operation in test file.

Please use the following template to submit a pull request, filling
in at least the "Text for release notes" and/or "Further details".
Thank You!

Description

see commit message

Text for release notes

Improved CoefficientsQadic for long results.

Checklist for pull request reviewers

  • proper formatting

  • usage of relevant labels

    1. either release notes: not needed or release notes: to be added
    2. at least one of the labels bug or enhancement or new feature
    3. for changes meant to be backported to stable-4.X add the backport-to-4.X label
    4. consider adding any of the labels build system, documentation, kernel, library, tests
  • runnable tests

  • lines changed in commits are sufficiently covered by the tests

  • adequate pull request title

  • well formulated text for release notes

  • relevant documentation updates

  • sensible comments in the code

This doesn't seem to be slower for small input, but is dramatically
faster for long return values (using a divide and conquer recursion).

Also added some calls of this operation in test file.
@frankluebeck frankluebeck added backport-to-4.10 kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: performance bugs or enhancements related to performance (improvements or regressions) labels Nov 24, 2020
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it's not a bugfix, so I am not sure why it should be backported to 4.11?

... not that it matters at this point, as we might as well release 4.12.0 next anyway shrug we'll see in spring

@frankluebeck
Copy link
Member Author

I've not added the "backport" label explicitly (just assumed that this was somehow added as default). Of course, I have an application for this and don't mind if the change goes into the next possible release.

@fingolfin fingolfin merged commit 941db82 into gap-system:master Dec 2, 2020
@ThomasBreuer ThomasBreuer self-assigned this Feb 16, 2021
@ThomasBreuer ThomasBreuer changed the title Improve CoeffientsQadic Improved the performance of CoeffientsQadic for long results. Feb 16, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@fingolfin fingolfin changed the title Improved the performance of CoeffientsQadic for long results. Improve the performance of CoeffientsQadic for long results Aug 17, 2022
@fingolfin fingolfin changed the title Improve the performance of CoeffientsQadic for long results Speed up CoefficientsQadic for long results Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: performance bugs or enhancements related to performance (improvements or regressions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants