-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up CoefficientsQadic
for long results
#4186
Speed up CoefficientsQadic
for long results
#4186
Conversation
This doesn't seem to be slower for small input, but is dramatically faster for long return values (using a divide and conquer recursion). Also added some calls of this operation in test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but it's not a bugfix, so I am not sure why it should be backported to 4.11?
... not that it matters at this point, as we might as well release 4.12.0 next anyway shrug we'll see in spring
I've not added the "backport" label explicitly (just assumed that this was somehow added as default). Of course, I have an application for this and don't mind if the change goes into the next possible release. |
CoeffientsQadic
for long results.
CoeffientsQadic
for long results.CoeffientsQadic
for long results
CoeffientsQadic
for long resultsCoefficientsQadic
for long results
This doesn't seem to be slower for small input, but is dramatically
faster for long return values (using a divide and conquer recursion).
Also added some calls of this operation in test file.
Please use the following template to submit a pull request, filling
in at least the "Text for release notes" and/or "Further details".
Thank You!
Description
see commit message
Text for release notes
Improved
CoefficientsQadic
for long results.Checklist for pull request reviewers
proper formatting
usage of relevant labels
release notes: not needed
orrelease notes: to be added
bug
orenhancement
ornew feature
stable-4.X
add thebackport-to-4.X
labelbuild system
,documentation
,kernel
,library
,tests
runnable tests
lines changed in commits are sufficiently covered by the tests
adequate pull request title
well formulated text for release notes
relevant documentation updates
sensible comments in the code