Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgap: enhance GAP_ValueGlobalVariable to supported automatic variables (see DeclareAutoreadableVariables) #4081

Merged
merged 1 commit into from
Jul 23, 2020
Merged

libgap: enhance GAP_ValueGlobalVariable to supported automatic variables (see DeclareAutoreadableVariables) #4081

merged 1 commit into from
Jul 23, 2020

Conversation

fingolfin
Copy link
Member

Automatic variables are relatively rare (not used by the GAP library, only by a few packages), but it makes sense to properly support them.

@fingolfin fingolfin added topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: libgap things related to libgap backport-to-4.11 labels Jul 23, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.0e-05%) to 85.749% when pulling f6104ed on fingolfin:mh/libgap-GVar into e6f3801 on gap-system:master.

@fingolfin fingolfin merged commit 084b640 into gap-system:master Jul 23, 2020
@fingolfin fingolfin deleted the mh/libgap-GVar branch July 24, 2020 16:09
@fingolfin
Copy link
Member Author

Backport to stable-4.11 in commit 4a1e458

@fingolfin fingolfin changed the title libgap: fix GAP_ValueGlobalVariable for automatic vars libgap: enhance GAP_ValueGlobalVariable to supported automatic variables (see DeclareAutoreadableVariables) Jul 30, 2020
@ThomasBreuer ThomasBreuer self-assigned this Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
backport-to-4.11-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fingolfin @coveralls @ChrisJefferson @ThomasBreuer @PaulaHaehndel