Use Info not Print in Decomposition
#3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, `DecompositionInt` and `Decomposition` used `Print` for showing a message whenever a new prime had to be chosen because the matrix in question was singular modulo the current prime. Meanwhile I have several real-world examples where this happens, which I want to use in package tests, and I think it is better to omit these messages by default, that is, to use `Info` instead of `Print`.
ThomasBreuer
added
topic: library
release notes: to be added
ChrisJefferson
approved these changes
Dec 20, 2019
PaulaHaehndel
added
release notes: added
fingolfin
added
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now,
DecompositionIntandDecompositionusedPrintfor showing a message whenever a new prime had to be chosen because
the matrix in question was singular modulo the current prime.
Meanwhile I have several real-world examples where this happens, which I want to use in package tests,
and I think it is better to omit these messages by default, that is, to use
Infoinstead ofPrint.Text for release notes
The functions
DecompositionandDecompositionIntdo no longer just print a messagewhenever a new prime has to be chosen because the matrix in question is singular modulo the current prime.
If one wants to see this message, one can set the info level of
InfoZLatticeto at least 1.