ENHANCE: Faster MaximalAbelianQuotient for subgroups of fp groups #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: enhancement
fingolfin
reviewed
Aug 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
==========================================
- Coverage 84.65% 84.42% -0.23%
==========================================
Files 698 698
Lines 345626 345611 -15
==========================================
- Hits 292582 291796 -786
- Misses 53044 53815 +771
|
Use abelianized rewriting rather than go though IsomorphismFpGroup. Also added heuristic relator matrix reduction (not full HNF) to use before SNF to speed up. Also use in case that kernel Abelian Rrs fails. LargerQuotientBySubgroupAbelianization will not calculate subgroup lattice to avoid overkill.
fingolfin
approved these changes
Sep 4, 2019
dimpase
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use abelianized rewriting rather than go though IsomorphismFpGroup.
Also added heuristic relator matrix reduction (not full HNF)
to use before SNF to speed up.
Also use in case that Abelian Rrs (in the kernel) fails.
This also includes a cleanup for #3634
Text for release notes
The performance of AbelianInvariants and MaximalAbelianQuotient for subgroups of fp groups has been improved.