WIP: Turn BaseField into a synonym of BaseDomain (DO NOT MERGE) #3562
+10
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
BaseField
was never documented. There are two packages that reference it, though:cvec
-- I already addressed that in a commit and will soon make another cvec release with that change in it (it should work with both GAP 4.10 and 4.11 that way)forms
(by @jdebeule et al) -- it installs aBaseField
method forIsForm
objects, which however are not inIsVectorObj
norIsMatrixObj
. This worked so far because we didDeclareOperation("BaseField",[IsObject]);
but now it doesn't, leading to an error when loading the package. I submitted a PR to make it useInstallOtherMethod
here: https://bitbucket.org/jdebeule/forms/pull-requests/1. However, that will only help once forms is released. In the meantime, we need another way to keepforms
working. This is the reason why I marked his PR as "do not merge" -- I am not quite sure how to proceed best.Of course we could just wait till there is a forms release before we apply this PR, and in the meantime, we could apply parts of it (i.e., replace any use of
BaseField
).Or perhaps we remove all uses of
BaseField
, but still leave itsBaseField
declaration in, and only install a single method which delegates toBaseDomain
. That declaration and the single method could go toobsolete.gd/.gi
.Or something else?
Thoughts, comments?