Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and correct documentation of CompositionMapping, add an example #3449

Merged
merged 1 commit into from
May 18, 2019

Conversation

ssiccha
Copy link
Contributor

@ssiccha ssiccha commented May 14, 2019

Clarifies the order in which the arguments of CompositionMapping are composed.
Adds an example.

@ssiccha ssiccha added kind: bug Issues describing general bugs, and PRs fixing them topic: documentation Issues and PRs related to documentation release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels May 14, 2019
@coveralls
Copy link

coveralls commented May 14, 2019

Coverage Status

Coverage remained the same at ?% when pulling 6049562 on ssiccha:ss/fix-CompositionMapping into f30c1e4 on gap-system:master.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I am not quite happy with the new phrasing.

lib/mapping.gd Outdated Show resolved Hide resolved
Clarifies the order in which the arguments are composed.
Adds an example.
@ssiccha ssiccha force-pushed the ss/fix-CompositionMapping branch from ebfdd80 to 6049562 Compare May 15, 2019 07:57
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #3449 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
+ Coverage   85.33%   85.34%   +<.01%     
==========================================
  Files         699      699              
  Lines      346465   346465              
==========================================
+ Hits       295673   295675       +2     
+ Misses      50792    50790       -2
Impacted Files Coverage Δ
lib/mapping.gd 100% <ø> (ø) ⬆️
src/iostream.c 65.9% <0%> (+0.75%) ⬆️

@fingolfin fingolfin changed the title doc: fix doc of CompositionMapping Clarify and correct documentation of CompositionMapping, add an example May 17, 2019
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@ChrisJefferson ChrisJefferson merged commit d536fa6 into gap-system:master May 18, 2019
@ssiccha ssiccha deleted the ss/fix-CompositionMapping branch August 7, 2019 08:48
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants