Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn NameFunction into an attribute so that custom function objects can implement support for it #3430

Merged
merged 1 commit into from
May 4, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Apr 29, 2019

This is a potential alternative to PR #3420. It needs some polishing and tests, but at least for some quick tests, seems to work reasonably well. I won't have time to work more on it for now, so if somebody else wants to continue with this, feel free to do so.

UPDATE: I have now improved this PR, it should be ready for merging.

@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage increased (+0.0007%) to 84.991% when pulling 6e88f65 on fingolfin:mh/NameFunction into c68edd6 on gap-system:master.

Previously, it was an operation that kind of acted like an attribute,
but not quite. Now one may use HasNameFunction, and also provide
custom methods for it for custom function types.
@fingolfin fingolfin changed the title WIP: turn NameFunction into a kernel attribute Turn NameFunction into a kernel attribute May 3, 2019
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #3430 into master will decrease coverage by 0.79%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #3430     +/-   ##
=========================================
- Coverage   84.97%   84.18%   -0.8%     
=========================================
  Files         699      698      -1     
  Lines      346081   345970    -111     
=========================================
- Hits       294087   291254   -2833     
- Misses      51994    54716   +2722
Impacted Files Coverage Δ
lib/function.gi 83.95% <100%> (+0.4%) ⬆️
src/calls.c 93.08% <100%> (+0.06%) ⬆️
lib/function.g 56.56% <100%> (+1.82%) ⬆️
lib/grpreps.gi 68% <0%> (-30%) ⬇️
lib/ffeconway.gi 69% <0%> (-17.5%) ⬇️
lib/grpramat.gi 73.06% <0%> (-16.61%) ⬇️
lib/gprd.gi 57.2% <0%> (-15.55%) ⬇️
lib/polyconw.gi 66.31% <0%> (-14.19%) ⬇️
lib/grplatt.gi 64.8% <0%> (-11.19%) ⬇️
lib/clashom.gi 73.19% <0%> (-7.91%) ⬇️
... and 126 more

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label May 3, 2019
@fingolfin fingolfin changed the title Turn NameFunction into a kernel attribute Turn NameFunction into an attribute May 3, 2019
@fingolfin
Copy link
Member Author

I just updated this PR, cleaning it up a bit, and adding some tests to ensure that the kernel attribute works as intended.

@ChrisJefferson ChrisJefferson merged commit 5c4ebe4 into gap-system:master May 4, 2019
@fingolfin fingolfin deleted the mh/NameFunction branch May 6, 2019 07:23
@fingolfin fingolfin changed the title Turn NameFunction into an attribute Turn NameFunction into an attribute so that custom function objects can implement support for it Aug 21, 2019
@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Aug 21, 2019
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants