Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change StructureDescription for infinite cyclic group #3267

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Change StructureDescription for infinite cyclic group #3267

merged 1 commit into from
Feb 6, 2019

Conversation

fingolfin
Copy link
Member

It used to be C0, now we refer to it as Z (as in: the integers), which
should be understood by more people without consulting the manual. Also,
the short name "0" is likewise replace by 0.

This is also consistent with what the RCWA package does in its custom
StructureDescription method.

@fingolfin
Change StructureDescription for infinite cyclic group
90e83d1 
It used to be C0, now we refer to it as Z (as in: the integers), which
should be understood by more people without consulting the manual. Also,
the short name "0" is likewise replace by 0.

This is also consistent with what the RCWA package does in its custom
StructureDescription method.
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 5, 2019
@fingolfin fingolfin requested a review from Stefan-Kohl February 5, 2019 23:20
@Stefan-Kohl
Copy link
Member

I think this change of notation for the infinite cyclic group looks o.k..

@fingolfin fingolfin merged commit 9520869 into gap-system:master Feb 6, 2019
@fingolfin fingolfin deleted the mh/StructureDescription-Z branch February 6, 2019 21:43
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@Stefan-Kohl Stefan-Kohl Awaiting requested review from Stefan-Kohl

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fingolfin @Stefan-Kohl @ChrisJefferson @olexandr-konovalov @DominikBernhardt