Make (Un)HideGlobalVariables obsolete #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions were never documented, and so far in all cases where they appear, there seem to be better, more robust alternatives, such as reading and evaluating external code inside a function context with suitable locals set, or by adapting the (interface to) the external code.
fingolfin
added
topic: library
release notes: to be added
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
==========================================
- Coverage 84.79% 84.74% -0.05%
==========================================
Files 687 688 +1
Lines 330800 335877 +5077
==========================================
+ Hits 280514 284653 +4139
- Misses 50286 51224 +938
|
ChrisJefferson
approved these changes
Jan 18, 2019
|
I agree this has always been super weird. |
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were never documented, and so far in all cases where they
appear, there seem to be better, more robust alternatives, such as reading and
evaluating external code inside a function context with suitable locals set,
or by adapting the (interface to) the external code.
IMHO, their existence promotes bad code design, which is why I'd like to make them obsolete and eventually remove them.