Fix crash when ApplicableMethod is called incorrectly #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we don't return garbage resp. don't trigger an assertion (in debug builds) when e.g. passing an argument list with 7 or more entries to ApplicableMethod.
fingolfin
force-pushed
the
mh/fix-ApplicableMethod-crash
branch
from
17748ef
to
ee1df98
Compare
Codecov Report
@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
- Coverage 83.66% 83.66% -0.01%
==========================================
Files 687 687
Lines 336685 336687 +2
==========================================
+ Hits 281697 281698 +1
- Misses 54988 54989 +1
|
ChrisJefferson
approved these changes
Jan 6, 2019
PaulaHaehndel
added
the
release notes: to be added
fingolfin
changed the title
fingolfin
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we don't return garbage resp. don't trigger an assertion (in debug builds) when e.g. passing an argument list with 7 or more entries to ApplicableMethod.
Fixes #3116