Fix NumberFFVector documentation, add an example #3079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation of NumberFFVector made it sound as if a value from 1 to q^n is returned, but it really returns a value from 0 to q^n-1. Also fix another unrelated typo in listcoef.gd.
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #3079 +/- ##
==========================================
+ Coverage 83.85% 83.85% +<.01%
==========================================
Files 688 688
Lines 343238 343219 -19
==========================================
- Hits 287818 287816 -2
+ Misses 55420 55403 -17
|
hulpke
approved these changes
Dec 3, 2018
Member
Author
|
Backported via 782bf18 |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of NumberFFVector made it sound as if a value from 1 to q^n is returned, but it really returns a value from 0 to q^n-1.
Also fix another unrelated typo in listcoef.gd.
This could be backported.