Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper function to get Stats from function bags #3036

Closed
wants to merge 1 commit into from
Closed

Add helper function to get Stats from function bags #3036

wants to merge 1 commit into from

Conversation

markuspf
Copy link
Member

This will be used in #2628 and could also be used in the GAP to C compiler.

@markuspf markuspf added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) do not comment yet PRs on which the author does not yet want any comment (e.g. only submitted for test results) do not review PRs which are not yet ready for a proper external review (e.g. only submitted for test results) labels Nov 20, 2018
@markuspf
Copy link
Member Author

Hold off commenting while I am trying to make a sensible PR.

@markuspf markuspf force-pushed the add-read-stat branch 2 times, most recently from 3de9738 to e0041b8 Compare November 20, 2018 17:08
@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9ee988f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3036   +/-   ##
=========================================
  Coverage          ?   83.76%           
=========================================
  Files             ?      685           
  Lines             ?   343392           
  Branches          ?        0           
=========================================
  Hits              ?   287657           
  Misses            ?    55735           
  Partials          ?        0
Impacted Files Coverage Δ
src/code.h 100% <100%> (ø)

@fingolfin
Copy link
Member

I don't think this is the way to go. Is there any point in keeping this PR open?

@markuspf markuspf closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin Awaiting requested review from fingolfin

Assignees
No one assigned
Labels
do not comment yet PRs on which the author does not yet want any comment (e.g. only submitted for test results) do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) do not review PRs which are not yet ready for a proper external review (e.g. only submitted for test results) kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuspf @fingolfin