Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: add libcurl for curlInterface; don't build Digraphs #2768

Merged
merged 2 commits into from
Sep 2, 2018

Conversation

olexandr-konovalov
Copy link
Member

@olexandr-konovalov olexandr-konovalov commented Sep 2, 2018

The new curlInterface requires libcurl4-openssl-dev. For the 32-bit build one should add libcurl4-openssl-dev:i386.

@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #2768 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2768      +/-   ##
==========================================
+ Coverage   75.81%   75.81%   +<.01%     
==========================================
  Files         481      481              
  Lines      241517   241517              
==========================================
+ Hits       183105   183106       +1     
+ Misses      58412    58411       -1
Impacted Files Coverage Δ
hpcgap/lib/hpc/stdtasks.g 64.19% <0%> (+0.25%) ⬆️

@olexandr-konovalov
Copy link
Member Author

Also, in 64-bit build, the test fail when it comes to loading digraphs: an undefined symbol: atexit error occur:

+bin/gap.sh --quitonbreak -q -L testpackagesload.wsp
Loading digraphs ... 
#W dlopen() error: /home/travis/build/gap-system/gap/pkg/digraphs-0.12.2/bin/x\
86_64-pc-linux-gnu-default64/digraphs.so: undefined symbol: atexit
Error, module '/home/travis/build/gap-system/gap/pkg/digraphs-0.12.2/bin/x86_64-pc-li\
nux-gnu-default64/digraphs.so' not found in
  if not LOAD_DYN( arg[1], false ) then
    Error( "no support for dynamic loading" );
fi; at /home/travis/build/gap-system/gap/lib/files.gd:583 called from 

@olexandr-konovalov
Copy link
Member Author

olexandr-konovalov commented Sep 2, 2018

@james-d-mitchell I have temporary disabled Digraphs build here, to avoid undefined symbol: atexit problem. We did the same with the Float package. We have seen this before for Digraphs - see digraphs/Digraphs#107. But Digraphs builds fine in GAP Docker container in both branches, and has perfectly runnable tests. I don't think there is a regression in Digraphs or/and core GAP system - seems that it also depends on some luck with getting the right Travis environment, which is outside our control.

P.S. And we already tried to revert that hack, and it worked for a while, until the problem reappeared: #2391

@olexandr-konovalov olexandr-konovalov changed the title Add libcurl for the curlInterface package Travis: add libcurl for curlInterface; don't build Digraphs Sep 2, 2018
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I still hope to fix the issues with digraphs, float and semigroups (e.g. via PR #2759), let's be pragmatic and fix the broken build now and then work on a "better" fix afterwards.

@fingolfin fingolfin merged commit c0c3307 into gap-system:master Sep 2, 2018
@fingolfin fingolfin added topic: tests issues or PRs related to tests release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Sep 12, 2018
@fingolfin fingolfin added topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ... and removed topic: tests issues or PRs related to tests labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants