-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce command line options --norepl
and --nointeract
, remove IsLIBGAP
constant
#2723
Conversation
IsLIBGAP
constant--noshell
, remove IsLIBGAP
constant
ff82976
to
0624c2c
Compare
Could be two PRs but the two commits are trivial enough I think. |
Seems sensible, it's a thing I've wanted before actually, when running GAP from a script. Super picky, should it be --norepl (or something like that) , just because you can still drop into the break loop and do things in there, which feels a bit like the shell, or should it automatically also enable --nobreakloop (do you want to always pair noshell with nobreakloop for your purposes?) |
Note, I'm happy for the option, and it's name, to be exactly what it is now, just wanted to see if it had been thought about :) |
I considered calling it You're right about the breakloop (when I tried it out here just now I ended up in the breakloop); For "libgap" purposes one would never want a break loop as far as I am concerned. Not sure whether one wants |
0624c2c
to
9899db6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
==========================================
- Coverage 75.78% 75.78% -0.01%
==========================================
Files 478 478
Lines 241434 241438 +4
==========================================
+ Hits 182974 182975 +1
- Misses 58460 58463 +3
|
9899db6
to
760ab13
Compare
@ChrisJefferson I introduced |
--noshell
, remove IsLIBGAP
constant--norepl
and --nointeract
, remove IsLIBGAP
constant
If anyone (maybe in particular @stevelinton @fingolfin @ChrisJefferson @sebasguts) has any opinions on the naming bikeshed (on these command line options), I am all ears. |
Those are fine names for me |
lib/system.g
Outdated
rec( long := "enableMemCheck", default := false) | ||
rec( long := "enableMemCheck", default := false), | ||
rec( long := "norepl", default := false, | ||
help := [ "Disable the GAP REPL" ] ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are people who don't know what a REPL is. There is also no help under ?REPL
. Of course one can google, but I'd prefer if we did not force people to do that. Can we perhaps expand this, e.g. by writing "Disable the GAP read-eval-print loop (REPL)" or so?
760ab13
to
f44599b
Compare
…AP shell * --norepl just disables the read-evaluate-print-loop, so GAP can still go into a break loop * --nointeract disables both the repl and the break loop
The presence of the `--norepl` command line option makes the `IsLIBGAP` constant obsolete, so we remove it.
f44599b
to
5857c97
Compare
@fingolfin updated the help text, and rebased on current master. I mentioned in the discussion before that "REPL" might not be as well-known a phrase as one might think, but also agreed with @ChrisJefferson that |
This is useful for "libgap" as introduced in #2702 and possibly using GAP in "batch mode" as one can leave out the
QUIT_GAP(0);
in GAP scripts.This makes the
IsLIBGAP
constant obsolete, so we remove it as well.