Encode if we have readline in workspaces #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2720 +/- ##
==========================================
+ Coverage 75.75% 75.75% +<.01%
==========================================
Files 478 478
Lines 241495 241501 +6
==========================================
+ Hits 182938 182944 +6
Misses 58557 58557
|
fingolfin
reviewed
Aug 21, 2018
src/saveload.c
Outdated
| { | ||
| static Char SyKernelDescription[256]; | ||
| strcpy(SyKernelDescription, SyKernelVersion); | ||
| if(SyUseReadline) |
There was a problem hiding this comment.
clang-format? add issue labels?
Perhaps we can setup a bot to point this out automatically, it's a bit tiresome. Alternatively, we can also agree to not bother about clang-format anymore, and just let everybody format whichever way they feel like?
There was a problem hiding this comment.
Id be happy with a bot. Maybe i can write a git script to run on my own machine that clangformats bevore each commit. (I actually do use formst on save on other projects i work on, but that reformats the whole file, so is no good for gap).
There was a problem hiding this comment.
Now reformatted
fingolfin
added
kind: bug
ChrisJefferson
force-pushed
the
workspace-readline
branch
from
f42a0fd
to
6543fc1
Compare
fingolfin
approved these changes
Aug 21, 2018
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode if readline is enabled in workspaces. Fixes #1079 and #1089
Also, will (hopefully) make it easier in future to add info to workspaces in a backwards compatible way (at least, backwards compatible that the errors will be reasonable when the workspace doesn't load).