Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forms for Omega(e,d,q), except when d odd, q even; some cleanup #2577

Merged
merged 5 commits into from
Jun 28, 2018

Conversation

fingolfin
Copy link
Member

Also added a new helper SetInvariantQuadraticFormFromMatrix which reduces some code duplication and as a side effect enforces the invariant B = Q + Q^tr, where B is the Gram matrix of the invariant bilinear form of an orthogonal group G, and Q is the Gram matrix of its invariant quadratic form.

The reason for excluding the case where d is odd, q is even, is described in issue #2576

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library labels Jun 26, 2018
@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #2577 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
- Coverage    74.6%    74.6%   -0.01%     
==========================================
  Files         481      481              
  Lines      242383   242354      -29     
==========================================
- Hits       180837   180812      -25     
+ Misses      61546    61542       -4
Impacted Files Coverage Δ
grp/classic.gi 95.62% <100%> (-0.12%) ⬇️
src/vec8bit.c 83.48% <0%> (+0.1%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.96% <0%> (+0.25%) ⬆️

@markuspf markuspf merged commit 463f89f into gap-system:master Jun 28, 2018
@fingolfin fingolfin deleted the mh/Omega-forms branch June 29, 2018 08:35
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants