Some more tests for the kernel #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: tests
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
+ Coverage 74.25% 74.29% +0.03%
==========================================
Files 482 482
Lines 245204 245181 -23
==========================================
+ Hits 182082 182162 +80
+ Misses 63122 63019 -103
|
fingolfin
commented
Jun 1, 2018
| */ | ||
| Obj FuncEmptyString( Obj self, Obj len ) | ||
| { | ||
| Obj new; | ||
| while ( ! IS_INTOBJ(len) ) { | ||
| while ( ! IS_NONNEG_INTOBJ(len) ) { |
There was a problem hiding this comment.
Strictly speaking this is a bug fix preventing OOB access. Perhaps should be mentioned in the commit message. Not sure if we care about it for release notes - perhaps a generic entry "improved input validation for several kernel functions"?
There was a problem hiding this comment.
I think some generic comment like that would be useful.
fingolfin
removed
the
release notes: not needed
fingolfin
commented
Jun 1, 2018
src/stringobj.c
Outdated
| "you can replace <trans> via 'return <trans>;'" ); | ||
| } | ||
|
|
||
| if ( GET_LEN_STRING( trans ) < 256 ) { |
There was a problem hiding this comment.
Oops, this must be changed to ˋelse ifˋ (user might have returned e.g. a boolean)
fingolfin
commented
Jun 1, 2018
tst/testinstall/kernel/stringobj.tst
Outdated
| 2 | ||
| gap> POSITION_SUBSTRING("abc","b",3); | ||
| fail | ||
| gap> POSITION_SUBSTRING("abc","x",3); |
fingolfin
force-pushed
the
mh/tests
branch
2 times, most recently
from
e1dedcc
to
da22cf8
Compare
In particular, replace recursion by loops where possible
|
@ChrisJefferson FYI I dropped the tabs->spaces changes. |
ChrisJefferson
approved these changes
Jun 1, 2018
| */ | ||
| Obj FuncEmptyString( Obj self, Obj len ) | ||
| { | ||
| Obj new; | ||
| while ( ! IS_INTOBJ(len) ) { | ||
| while ( ! IS_NONNEG_INTOBJ(len) ) { |
There was a problem hiding this comment.
I think some generic comment like that would be useful.
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.