Finite groups of order not divisible by 4 are solvable #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
stevelinton
approved these changes
May 28, 2018
lib/grp.gi
Outdated
| ## any non-solvable finite group is a multiple of 4. | ||
| InstallImmediateMethod( IsSolvableGroup, IsGroup and HasSize, 10, | ||
| function( G ) | ||
| G:= Size( G ); |
Contributor
There was a problem hiding this comment.
I appreciate that this is not code added in the patch, but personally I really don't like
this reuse of G. Adding a new local variable would add one line of source and 8 bytes of stack frame.
fingolfin
force-pushed
the
mh/twice-odd-is-solvable
branch
from
fd661b0 to
53d077f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
+ Coverage 74.27% 74.27% +<.01%
==========================================
Files 484 484
Lines 245343 245343
==========================================
+ Hits 182217 182218 +1
+ Misses 63126 63125 -1
|
stevelinton
approved these changes
May 28, 2018
fingolfin
force-pushed
the
mh/twice-odd-is-solvable
branch
from
53d077f to
e456443
Compare
This is a simple extension of the odd order theorem. See comment inside the patch.
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple extension of the odd order theorem. See comment
inside the patch.