kernel: access TmpPPerm via ADDR_PPERM4 #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 74.27% 74.27% +<.01%
==========================================
Files 484 484
Lines 245340 245343 +3
==========================================
+ Hits 182215 182218 +3
Misses 63125 63125
|
There was a problem hiding this comment.
This looks ok to me, mod the following comment. Given that the first two sizeof(Obj) in TmpPPerm were previously being used, are you sure that enough space is being allocated by ResizeTmpPerm before it is used? I.e. this change effectively makes TmpPPerm shorter by 2 * sizeof(Obj) so it would be good to verify that there is no out of bounds accesses caused by this change.
|
@james-d-mitchell yes, I checked for that, and the resizing code for the tmpperm already added these two Obj slots, plus an extra UInt4 slot (for the degree). |
james-d-mitchell
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493
Not for release notes, as this does not actually effect GASMAN or Boehm GC; only with Julia GC will it play a role.