Improve Is{Constant,Univariate}RationalFunction, add tests #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 74.06% 74.14% +0.07%
==========================================
Files 484 484
Lines 245498 245545 +47
==========================================
+ Hits 181830 182057 +227
+ Misses 63668 63488 -180
|
|
I just extended this some more, adding helpers for multiplying rational numbers with rational functions over e.g. finite fields (we already have such helpers for addition). |
|
@fingolfin The helper functions were not added to the HPC-GAP folder. :) |
fingolfin
force-pushed
the
mh/test-ratfun
branch
3 times, most recently
from
6550857
to
b3f78f1
Compare
* Change IsConstantRationalFunction and IsUnivariateRationalFunction to return false for objects which are not even rational functions * Improve UNIVARTEST_RATFUN to deal with some more "trivial" cases before giving up * Add convenience helpers for multiplying rational numbers by rational functions over rings which don't contain the rational numbers, complementing the existing helpers doing this for addition * Add tests
fingolfin
added
kind: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return false for objects which are not even rational functions
giving up
functions over rings which don't contain the rational numbers,
complementing the existing helpers doing this for addition