kernel: remove partial floats in scanner; fix support for identifiers of length 1023 and more #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
added
kind: bug
fingolfin
force-pushed
the
mh/no-partial-float
branch
from
364c4f0
to
94a3a96
Compare
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
+ Coverage 74.01% 74.03% +0.01%
==========================================
Files 484 484
Lines 245371 245274 -97
==========================================
- Hits 181615 181581 -34
+ Misses 63756 63693 -63
|
The manual says that identifiers are truncated to 1023 chars, i.e., an identifier has *at most* 1023 chars. But some of our code instead restricted them to *less* than 1023 chars, i.e., the maximum was 1022. We now do what the manual has been saying since forever.
stevelinton
approved these changes
May 16, 2018
fingolfin
added
the
release notes: added
olexandr-konovalov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally gets rid of the remaining
S_PARTIALFLOAT*scanner states, simplifying parsing/scanning of float literals further.It also fixes our treatment of overlong identifiers: the manual has always claimed that these are truncated at 1023 chars, but instead truncated to 1022 chars. I changed this to match the manual, as there is really no technical reason to truncate at 1022, and no serious existing code can be affected negatively by adding support for slightly longer identifiers.
While at it, I also made some other minor scanner/reader cleanups.
Fixes #1104