Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for last2 and last3 in break loop #2379

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Add test for last2 and last3 in break loop #2379

merged 1 commit into from
Apr 20, 2018

Conversation

fingolfin
Copy link
Member

This is a test for the fix in #2375

@fingolfin fingolfin added topic: tests issues or PRs related to tests release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Apr 19, 2018
@codecov
Copy link

codecov bot commented Apr 19, 2018 •
edited
Loading

Codecov Report

Merging #2379 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
+ Coverage   73.69%   73.69%   +<.01%     
==========================================
  Files         484      484              
  Lines      245655   245655              
==========================================
+ Hits       181036   181040       +4     
+ Misses      64619    64615       -4
Impacted Files Coverage Δ
src/hpc/threadapi.c 43.3% <0%> (-0.11%) ⬇️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (+1.27%) ⬆️

cdwensley
cdwensley approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@cdwensley cdwensley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does just what it claims to do. Thank you for the guidance giving me the opportunity create this PR myself - pity it would not work!

@fingolfin fingolfin merged commit 583ed03 into gap-system:master Apr 20, 2018
@fingolfin fingolfin deleted the mh/test-last2-last3 branch April 20, 2018 20:02
@cdwensley cdwensley mentioned this pull request Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdwensley cdwensley cdwensley approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @cdwensley