Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status of obsoletes, and disable some of them #2335

Merged
merged 2 commits into from
Apr 2, 2018

Conversation

fingolfin
Copy link
Member

No description provided.

We can fully remove it at a later time, say after GAP 4.10 has been
released (and people thus had plenty opportunity to complain)
@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #2335 into master will increase coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   72.74%   72.82%   +0.08%     
==========================================
  Files         477      478       +1     
  Lines      241703   246444    +4741     
==========================================
+ Hits       175823   179478    +3655     
- Misses      65880    66966    +1086
Impacted Files Coverage Δ
lib/obsolete.gd 79.16% <ø> (+17.87%) ⬆️
lib/obsolete.gi 0% <0%> (ø) ⬆️
src/lists.c 66.62% <0%> (-4.97%) ⬇️
src/vector.c 95.14% <0%> (-4.86%) ⬇️
src/iostream.c 58.11% <0%> (-3.74%) ⬇️
src/blister.c 81.72% <0%> (-3.56%) ⬇️
src/streams.c 60.17% <0%> (-3.54%) ⬇️
src/range.c 90.25% <0%> (-3.5%) ⬇️
src/hookintrprtr.c 66.32% <0%> (-3.24%) ⬇️
src/vecffe.c 72.06% <0%> (-2.94%) ⬇️
... and 95 more

Copy link
Member

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Disabled obsoletes were moved to obsoletes reasonable time ago. Still good to keep them commented out, in case we need to review them (or someone will not find them and will be grep'ing the library).

@fingolfin fingolfin merged commit 88912b1 into gap-system:master Apr 2, 2018
@fingolfin fingolfin deleted the mh/obsolete branch April 2, 2018 20:15
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants